Dimchikkk commented on PR #13364: URL: https://github.com/apache/datafusion/pull/13364#issuecomment-2469020556
> Thanks @Dimchikkk for your contribution. Do you mean the Entry API misbehaved returning Vacant all the time and forced the regexp pattern to be recompiled? Hi @comphead , No, I haven't found out the root cause why the code using Entry API less performant. I went from another angle... looking into regexp_replace source file (that was like 50% faster) and trying to do things in a similar way & benchmark it.... so I basically rewrote the function that inserts into the cache. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
