Dandandan commented on code in PR #13364:
URL: https://github.com/apache/datafusion/pull/13364#discussion_r1838044447
##########
datafusion/functions/src/regex/regexpcount.rs:
##########
@@ -343,7 +342,7 @@ where
.map(|(value, flags)| {
let pattern =
compile_and_cache_regex(regex, flags, &mut
regex_cache)?;
- count_matches(value, &pattern, start_scalar)
+ count_matches(value, pattern, start_scalar)
Review Comment:
Ah nvm, the flag is non-scalar in this example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
