comphead commented on code in PR #13369:
URL: https://github.com/apache/datafusion/pull/13369#discussion_r1837359254
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -852,6 +852,54 @@ fn get_corrected_filter_mask(
corrected_mask.extend(vec![Some(true); null_matched]);
Some(corrected_mask.finish())
}
+ JoinType::Full => {
+ let mut mask: Vec<Option<bool>> = vec![Some(true);
row_indices_length];
+ let mut last_true_idx = 0;
+ let mut first_row_idx = 0;
+ let mut seen_false = false;
+
+ for i in 0..row_indices_length {
Review Comment:
the mask processing is more complex compared to other join types, I'm
planning to add more tests and documentation preferably in follow up PR, but if
its a blocker for the review I'll update this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
