comphead commented on code in PR #13369:
URL: https://github.com/apache/datafusion/pull/13369#discussion_r1840758311
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -852,6 +852,54 @@ fn get_corrected_filter_mask(
corrected_mask.extend(vec![Some(true); null_matched]);
Some(corrected_mask.finish())
}
+ JoinType::Full => {
+ let mut mask: Vec<Option<bool>> = vec![Some(true);
row_indices_length];
Review Comment:
unlike to other join types its needed to update current array, the builder
does append only afaik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
