jonathanc-n commented on code in PR #13366:
URL: https://github.com/apache/datafusion/pull/13366#discussion_r1837377929
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1490,6 +1491,92 @@ mod tests {
);
}
+ #[test]
+ fn test_numeric_string_coercion_with_utf8view() {
+ assert_eq!(
Review Comment:
I'm a bit confused, the function is used
[here](https://github.com/apache/datafusion/blob/7ebd993fe47e78006bad33256160716f73b13cef/datafusion/expr-common/src/type_coercion/binary.rs#L532).
If reverted, the change will fail the current added test but no other tests.
This means that the changes allow support for `Utf8View` in
`numeric_string_conversion`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
