jayzhan211 commented on code in PR #13366:
URL: https://github.com/apache/datafusion/pull/13366#discussion_r1837783578
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1490,6 +1491,92 @@ mod tests {
);
}
+ #[test]
+ fn test_numeric_string_coercion_with_utf8view() {
+ assert_eq!(
Review Comment:
If I understand correctly, your test is unit test, it failed if the change
reverted but it doesn't mean the change effects the actual query ~(I guess
after we change the signature for most of the function, numeric string coercion
might not be used at all)~. I suggest we add end2end test (slt) instead of unit
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
