Nyrox commented on PR #1435: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1435#issuecomment-2470589821
Okay, I wrote some documentation and fixed up the tests so CI should pass now (I hope :P ) Let me know what you think of the docs, I wasn't quite sure what to write so I hope it's decent. @iffyio I ended up running into the problem we discussed further up about comparing queries. It slipped by me that Tokens store the raw string in addition to the Keyword enum, causing `select 5` and `SELECT 5` to compare as unequal. I have added a new wrapper type `IgnoreField` to work around this issue and make sure the tokens actually do not impact semantics. I am not exactly sure if this is _the best_ fix, but I think if we want queries to compare as semantically equal rather than syntactically then this is a decent solution for now. lmk what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
