Nyrox commented on code in PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#discussion_r1846077090
##########
src/ast/mod.rs:
##########
@@ -140,8 +145,39 @@ pub struct Ident {
/// The starting quote if any. Valid quote characters are the single quote,
/// double quote, backtick, and opening square bracket.
pub quote_style: Option<char>,
+ /// The span of the identifier in the original SQL string.
+ pub span: Span,
+}
+
+impl PartialEq for Ident {
+ fn eq(&self, other: &Self) -> bool {
+ let Ident {
+ value,
+ quote_style,
+ // backwards compat
Review Comment:
yup 👍
##########
src/ast/query.rs:
##########
@@ -276,6 +280,8 @@ impl fmt::Display for Table {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
pub struct Select {
+ /// SELECT
+ pub select_token: IgnoreField<TokenWithLocation>,
Review Comment:
yup 👍
##########
src/ast/query.rs:
##########
@@ -556,6 +563,8 @@ pub struct Cte {
pub query: Box<Query>,
pub from: Option<Ident>,
pub materialized: Option<CteAsMaterialized>,
+ // needed for accurate span reporting
Review Comment:
yup 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
