Omega359 commented on code in PR #13356:
URL: https://github.com/apache/datafusion/pull/13356#discussion_r1839178374
##########
datafusion/functions/src/core/nullif.rs:
##########
@@ -61,9 +41,13 @@ impl Default for NullIfFunc {
impl NullIfFunc {
pub fn new() -> Self {
Self {
- signature: Signature::uniform(
- 2,
- SUPPORTED_NULLIF_TYPES.to_vec(),
+ signature: Signature::one_of(
+ // Hack: String is at the beginning so the return type is
String if both args are Nulls
Review Comment:
Not sure I'd call that a hack tbh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
