jayzhan211 commented on code in PR #13356:
URL: https://github.com/apache/datafusion/pull/13356#discussion_r1839288531
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -477,6 +483,33 @@ fn get_valid_types(
vec![vec![base_type_or_default_type(&coerced_type); *number]]
}
+ TypeSignature::Boolean(number) => {
+ function_length_check(current_types.len(), *number)?;
+
+ // Find common boolean type amongs given types
+ let mut valid_type = current_types.first().unwrap().to_owned();
Review Comment:
This is to ensure the given types are all boolean, if it isn't we should
return error here. If we got null, we return boolean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
