ding-young commented on code in PR #13328:
URL: https://github.com/apache/datafusion/pull/13328#discussion_r1839338606
##########
datafusion/core/tests/parquet/external_access_plan.rs:
##########
@@ -313,7 +313,7 @@ impl TestFull {
} = self;
let TestData {
- temp_file: _,
+ _temp_file: _,
Review Comment:
I updated the comments, but I'm a bit confused yet :cry:
If we need to keep the `_temp_file` around through the end of the function
`run()`, don't we need to actually bind `_temp_file` instead of `_temp_file :
_` ? Or is it fine to drop `_temp_file` right after `get_test_data()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
