alamb commented on code in PR #13328:
URL: https://github.com/apache/datafusion/pull/13328#discussion_r1839496115
##########
datafusion/core/tests/parquet/external_access_plan.rs:
##########
@@ -313,7 +313,7 @@ impl TestFull {
} = self;
let TestData {
- temp_file: _,
+ _temp_file: _,
Review Comment:
I tried it out as it wasn't obvious to me from the code -- it seems like
`get_test_data()` actually returns a *reference* to `&'static TestData` -- so
it doesn't actually matter if the `_temp_file` field is bound or not locally -
`Drop` isn't done until the process quits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
