milenkovicm commented on PR #1100:
URL:
https://github.com/apache/datafusion-ballista/pull/1100#issuecomment-2474778661
I had a quick look at the PR
I think you're overcomplicating it a bit,
if we go back to original idea
```python
from Ballista import Builder
ctx : SessionContext = Ballista.builder.config("ballista.job.name","Super
Cool Ballista Python Job").standalone()
```
you just need `BallistaBuilder` to cover whole flow, no need to introduce
`SessionConfig` or `SessionState`
```rust
struct BallistaBuilder {
confg: HashMap<String,String>
}
impl BallistaBuilder {
fn conf(self, key: String, value: String) -> Self {
self.conf.insert(key, value)
self
}
fn standalone(self) -> PySessionContext {
// create SessionConfig
// create SessionState
// create SessionContext
PySessionContext { ctx }
}
}
```
wdyt @tbar4 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
