sgrebnov commented on code in PR #13405:
URL: https://github.com/apache/datafusion/pull/13405#discussion_r1841553668
##########
datafusion/sql/src/unparser/plan.rs:
##########
@@ -157,10 +157,95 @@ impl Unparser<'_> {
)]);
}
+ // Construct a list of all the identifiers present in query sources
+ let mut all_idents = Vec::new();
Review Comment:
Wondering if this can be wrapped to a helper function like
`collect_valid_idents` or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
