jayzhan211 commented on code in PR #13372:
URL: https://github.com/apache/datafusion/pull/13372#discussion_r1845412004
##########
datafusion/common/src/types/native.rs:
##########
@@ -433,4 +433,29 @@ impl NativeType {
UInt8 | UInt16 | UInt32 | UInt64 | Int8 | Int16 | Int32 | Int64
)
}
+
+ #[inline]
Review Comment:
I think so. We used it a lot in arrow-rs for trivial function too. Functions
such as `matches` macro that has lower cost than the function called overhead,
so inline them are better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
