peter-toth commented on PR #13467: URL: https://github.com/apache/datafusion/pull/13467#issuecomment-2484069956
> > Adds the Container trait and blanket implementations for Box, Option, Vec, tuples, ... > > Do we need that? > > What about calling this trait TreeNode or GraphNode and implementing it for our types only? Yes, we do. We already have the `TreeNode` trait with a well defined API. It has `TreeNode::apply_children()` / `TreeNode::map_children()` to let the tree implementations define how to visit/map the children of a node. This new `Container` trait with the above mentioned blankets just make the implementation of that `apply_children()` / `map_children()` of logical plan trees (`Expr` and `LogicalPlan`) simpler. We can actually move `Container` and its blanket implementations to `datafusion::expr` if that's cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
