comphead commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1847350883
##########
datafusion/doc-gen/src/lib.rs:
##########
@@ -190,7 +177,7 @@ impl DocumentationBuilder {
self
}
- pub fn build(self) -> Result<Documentation> {
+ pub fn build(self) -> Documentation {
Review Comment:
Done. I was thinking to convert the builder to support constructor `new`
with mandatory arguments so we dont need having this panics, I'll do it in
follow up PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
