alamb commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1848211730
##########
datafusion/doc-gen/src/lib.rs:
##########
@@ -190,7 +177,7 @@ impl DocumentationBuilder {
self
}
- pub fn build(self) -> Result<Documentation> {
+ pub fn build(self) -> Documentation {
Review Comment:
I like that idea
##########
Cargo.toml:
##########
@@ -100,6 +102,7 @@ datafusion = { path = "datafusion/core", version =
"43.0.0", default-features =
datafusion-catalog = { path = "datafusion/catalog", version = "43.0.0" }
datafusion-common = { path = "datafusion/common", version = "43.0.0",
default-features = false }
datafusion-common-runtime = { path = "datafusion/common-runtime", version =
"43.0.0" }
+datafusion-doc = { path = "datafusion/doc-gen", version = "43.0.0" }
Review Comment:
looks like the directory name is still `doc` when calling it `doc` would be
more consistent with the others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
