kazuyukitanimura commented on code in PR #1095:
URL: https://github.com/apache/datafusion-comet/pull/1095#discussion_r1847453824
##########
native/core/src/parquet/read/values.rs:
##########
@@ -586,8 +586,6 @@ macro_rules! generate_cast_to_unsigned {
};
}
-generate_cast_to_unsigned!(copy_i32_to_u8, i32, u8, 0_u8);
-generate_cast_to_unsigned!(copy_i32_to_u16, i32, u16, 0_u16);
generate_cast_to_unsigned!(copy_i32_to_u32, i32, u32, 0_u32);
Review Comment:
`copy_i32_to_u32` stays in the current logic as it is for widening `i32` ->
`i64(u32)`, so we need to pad zeros
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
