viirya commented on code in PR #1095: URL: https://github.com/apache/datafusion-comet/pull/1095#discussion_r1847602243
########## spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala: ########## @@ -434,8 +434,8 @@ abstract class ParquetReadSuite extends CometTestBase { i.toFloat, i.toDouble, i.toString * 48, - java.lang.Byte.toUnsignedInt((-i).toByte), - java.lang.Short.toUnsignedInt((-i).toShort), Review Comment: I meant that you changed this expected results to match what Comet returns, but are they same as Spark returns? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org