wugeer commented on code in PR #1531:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1531#discussion_r1847638591
##########
src/dialect/mod.rs:
##########
@@ -638,6 +638,11 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Returns true if the dialect supports the `UNLISTEN` statement
+ fn supports_unlisten(&self) -> bool {
+ false
+ }
Review Comment:
Yes, although this part of the syntax might be closely related, I think it's
better to separate them as independent features. This is because `listen`,
`unlisten` and `notify` might not necessarily be supported together. On this
issue, perhaps we could get more input from others to consider it more
comprehensively. What do you think? @iffyio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
