mvzink commented on code in PR #1539:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1539#discussion_r1851117987
##########
src/ast/mod.rs:
##########
@@ -195,14 +199,36 @@ impl fmt::Display for Ident {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
-pub struct ObjectName(pub Vec<Ident>);
+pub struct ObjectName(pub Vec<ObjectNamePart>);
+
+impl From<Vec<Ident>> for ObjectName {
+ fn from(idents: Vec<Ident>) -> Self {
+
ObjectName(idents.into_iter().map(ObjectNamePart::Identifier).collect())
+ }
+}
impl fmt::Display for ObjectName {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "{}", display_separated(&self.0, "."))
}
}
+/// A single part of an ObjectName
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub enum ObjectNamePart {
+ Identifier(Ident),
+}
+
+impl fmt::Display for ObjectNamePart {
+ fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+ match self {
+ ObjectNamePart::Identifier(ident) => write!(f, "{}", ident),
Review Comment:
nit: I prefer `ident.fmt(f)`
##########
src/parser/mod.rs:
##########
@@ -12579,7 +12599,9 @@ impl<'a> Parser<'a> {
.parse_one_of_keywords(&[Keyword::FROM, Keyword::IN])
.is_some()
{
- parent_name.0.insert(0, self.parse_identifier(false)?);
+ parent_name
+ .0
+ .insert(0,
self.parse_identifier(false)?.to_object_name_part());
Review Comment:
Based on this one usage (and I don't see another one in your snowflake PR),
couldn't `to_object_name_part` just take ownership and rewrap instead of
cloning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
