alamb commented on code in PR #13290:
URL: https://github.com/apache/datafusion/pull/13290#discussion_r1852464362
##########
datafusion/expr/src/udf.rs:
##########
@@ -324,26 +328,37 @@ where
}
}
-/// Trait for implementing [`ScalarUDF`].
+pub struct ScalarFunctionArgs<'a> {
+ // The evaluated arguments to the function
+ pub args: &'a [ColumnarValue],
+ // The number of rows in record batch being evaluated
+ pub number_rows: usize,
+ // The return type of the scalar function returned (from `return_type` or
`return_type_from_exprs`)
+ // when creating the physical expression from the logical expression
+ pub return_type: &'a DataType,
Review Comment:
(BTW the change in the design to a struct I think allows for much easier
non-breaking API additions in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
