Eason0729 commented on PR #12939: URL: https://github.com/apache/datafusion/pull/12939#issuecomment-2492890839
This PR duplicates some of the function that return Expr(sqlparser) and add _with_alias to their name(change return type to `ExprWithAlias` simultaneously). However, I thinks the duplication is unneeded for function that return Expr(datafusion), because datafusion already have Alias entry in [Expr enum](https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.Expr.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
