milenkovicm commented on code in PR #12939:
URL: https://github.com/apache/datafusion/pull/12939#discussion_r1863370988
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -1195,4 +1195,25 @@ mod tests {
test_stack_overflow!(2048);
test_stack_overflow!(4096);
test_stack_overflow!(8192);
+ #[test]
+ fn test_sql_to_expr_with_alias() {
+ let schema = DFSchema::empty();
+ let mut planner_context = PlannerContext::default();
+
+ let expr_str = "int_col as int_col_alias";
Review Comment:
thanks @Eason0729, IMHO this looks good, can we get another test which will
test expression with function as well, something like `SUM(int_col) as
sum_int_col` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
