milenkovicm opened a new pull request, #1129:
URL: https://github.com/apache/datafusion-ballista/pull/1129
there was a bit of repeatibility in the test, same tests were used for
`standalone` and `remote` context.
this PR introduces:
- rstest to parametrise tests, so we can re-use tests for `standalone` and
`remote`
- enable previously ignored tests due to unsupported functionality (like
`INSERT INTO`) to catch if datafusion brings new changes
- testcontainers tests moved to example to reduce duplication (they are
still disabled as i could not make them connect to docker deamon)
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes none.
# Rationale for this change
simplification and de-duplication of tests
# What changes are included in this PR?
- rstest to parametrise tests, so we can re-use tests for `standalone` and
`remote`
- enable previously ignored tests due to unsupported functionality (like
`INSERT INTO`) to catch if datafusion brings new changes
- testcontainers tests moved to example to reduce duplication (they are
still disabled as i could not make them connect to docker deamon)
# Are there any user-facing changes?
No, just tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
