alamb commented on PR #13370:
URL: https://github.com/apache/datafusion/pull/13370#issuecomment-2499103831
I am trying to clean up the review backlog -- what is the status of this PR?
It seems like it is waiting on an end to end (e.g. sql or dataframe test)
that actually has a problem / doesn't run without this PR but does run with it
I played around with it and I think I came up with one:
```sql
> create or replace table foo as select arrow_cast('1', 'Utf8View') as c;
0 row(s) fetched.
Elapsed 0.002 seconds.
> select c from foo;
+---+
| c |
+---+
| 1 |
+---+
1 row(s) fetched.
Elapsed 0.001 seconds.
> select c = 1 from foo;
Error during planning: Cannot infer common argument type for comparison
operation Utf8View = Int64
```
But it works for strings:
```sql
> create or replace table foo as select arrow_cast('1', 'Utf8') as c;
0 row(s) fetched.
Elapsed 0.002 seconds.
> select c = 1 from foo;
+------------------+
| foo.c = Int64(1) |
+------------------+
| true |
+------------------+
1 row(s) fetched.
Elapsed 0.002 seconds.
```
Looks like we need to test with `Utf8` + `Utf8View` (aka string concat)
Also since the argument type order is important, also in both directions
Does that make sense @jonathanc-n ?
Thank you for your help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
