iffyio commented on code in PR #1547:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1547#discussion_r1858582676
##########
src/parser/mod.rs:
##########
@@ -11411,6 +11411,9 @@ impl<'a> Parser<'a> {
Token::Colon if
self.dialect.supports_named_fn_args_with_colon_operator() => {
Ok(FunctionArgOperator::Colon)
}
+ Token::Word(w) if w.value.eq_ignore_ascii_case("value") => {
Review Comment:
would it make sense to have value be a keyword so that this can potentially
become `if self.parse_keyword(Keyword::VALUE)`?
##########
tests/sqlparser_postgres.rs:
##########
@@ -2812,6 +2812,19 @@ fn test_json() {
);
}
+#[test]
+fn test_json_object() {
Review Comment:
```suggestion
fn test_fn_arg_with_value_operator() {
```
thinking or something more generic? since the feature can apply in other
cases and json_object has other variants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
