lovasoa commented on code in PR #1547:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1547#discussion_r1858873594


##########
tests/sqlparser_postgres.rs:
##########
@@ -2812,6 +2812,19 @@ fn test_json() {
     );
 }
 
+#[test]
+fn test_json_object() {

Review Comment:
   I applied your suggestion. But this feature really should not apply to other 
functions. The syntax `'key' VALUE 'value'` is specific to json_object and will 
not be parsed by actual databases in arbitrary functions. The decision to parse 
this as a generic function call instead of a particular expression was taken in 
https://github.com/apache/datafusion-sqlparser-rs/pull/1507#discussion_r1835440360
 , so I did not come back on the design.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to