alamb commented on code in PR #13564:
URL: https://github.com/apache/datafusion/pull/13564#discussion_r1861273331
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs:
##########
@@ -190,9 +191,13 @@ impl<T: ArrowPrimitiveType, const NULLABLE: bool>
GroupColumn
assert!(nulls.is_none(), "unexpected nulls in non nullable input");
}
- let arr = PrimitiveArray::<T>::new(ScalarBuffer::from(group_values),
nulls);
+ let arr = PrimitiveArray::<T>::new(ScalarBuffer::from(group_values),
nulls)
+ .with_data_type(data_type.clone());
+ let array_ref = Arc::new(arr) as ArrayRef;
+
// Set timezone information for timestamp
- Arc::new(arr.with_data_type(data_type))
+ adjust_output_array(&data_type, array_ref)
Review Comment:
I tried backing out the use of adjust_data_type and I didn't see any
failures locally 🤔
##########
datafusion/core/tests/fuzz_cases/aggregation_fuzzer/data_generator.rs:
##########
@@ -87,7 +87,12 @@ impl DatasetGeneratorConfig {
.iter()
.filter_map(|d| {
if d.column_type.is_numeric()
- && !matches!(d.column_type, DataType::Float32 |
DataType::Float64)
+ && !matches!(
Review Comment:
Something is wrong here. This change effectively turns off fuzz testing for
sum with decimal:
When I reverted this change the fuzz tests fail occasionally like this:
```
test fuzz_cases::aggregate_fuzz::test_sum ... FAILED
...
Arrow error: Invalid argument error: column types must match schema types,
expected Decimal128(21, -112) but found Decimal128(38, 10) at column index 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
