jayzhan211 commented on code in PR #13564:
URL: https://github.com/apache/datafusion/pull/13564#discussion_r1865774046
##########
datafusion/core/tests/fuzz_cases/aggregation_fuzzer/data_generator.rs:
##########
@@ -87,7 +87,12 @@ impl DatasetGeneratorConfig {
.iter()
.filter_map(|d| {
if d.column_type.is_numeric()
- && !matches!(d.column_type, DataType::Float32 |
DataType::Float64)
+ && !matches!(
Review Comment:
```
statement ok
create table t as values (arrow_cast(21, 'Decimal128(20, 3)'), 1),
(arrow_cast(11, 'Decimal128(20, 3)'), 2);
query RR
select sum(column1), sum(distinct column1) from t group by column2;
----
11 11
21 21
query TT
select arrow_typeof(sum(column1)), arrow_typeof(sum(distinct column1)) from
t group by column2;
----
Decimal128(38, 3) Decimal128(30, 3)
Decimal128(38, 3) Decimal128(30, 3)
```
Decimal128(30, 3) is precision used in grouping
Decimal128(38, 3) is the normal fixed precision in sum
##########
datafusion/core/tests/fuzz_cases/aggregation_fuzzer/data_generator.rs:
##########
@@ -87,7 +87,12 @@ impl DatasetGeneratorConfig {
.iter()
.filter_map(|d| {
if d.column_type.is_numeric()
- && !matches!(d.column_type, DataType::Float32 |
DataType::Float64)
+ && !matches!(
Review Comment:
```
statement ok
create table t as values (arrow_cast(21, 'Decimal128(20, 3)'), 1),
(arrow_cast(11, 'Decimal128(20, 3)'), 2);
query RR
select sum(column1), sum(distinct column1) from t group by column2;
----
11 11
21 21
query TT
select arrow_typeof(sum(column1)), arrow_typeof(sum(distinct column1)) from
t group by column2;
----
Decimal128(38, 3) Decimal128(30, 3)
Decimal128(38, 3) Decimal128(30, 3)
```
Decimal128(30, 3) is precision used in grouping
Decimal128(38, 3) is the normal precision in sum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
