comphead commented on code in PR #13575:
URL: https://github.com/apache/datafusion/pull/13575#discussion_r1861309268
##########
datafusion/functions/src/core/arrow_cast.rs:
##########
@@ -147,10 +147,10 @@ static DOCUMENTATION: OnceLock<Documentation> =
OnceLock::new();
fn get_arrow_cast_doc() -> &'static Documentation {
DOCUMENTATION.get_or_init(|| {
- Documentation::builder()
- .with_doc_section(DOC_SECTION_OTHER)
- .with_description("Casts a value to a specific Arrow data type.")
- .with_syntax_example("arrow_cast(expression, datatype)")
+ Documentation::builder(
+ DOC_SECTION_OTHER,
Review Comment:
thanks @alamb. imho, it is regular builder pattern for the object
construction which has both mandatory fields(in constructor) and optional
fields(set by builder).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
