Rachelint commented on issue #13275: URL: https://github.com/apache/datafusion/issues/13275#issuecomment-2506290147
I tried the possible optimizations for`vectorized_equal_to`: https://github.com/apache/datafusion/pull/12996#discussion_r1818601807 https://github.com/apache/datafusion/pull/12996#discussion_r1823151542 But unfortunately seems no obvious improvement in clickbench, tpch and so on... although some improvement can see in benchmark for the function in https://github.com/apache/datafusion/pull/13539 For `take + eq`, use `eq` in arrow kernel indeed can get performance improve, but the cost of `take` seems unacceptable... For optimizations for special case of `input array` (like `all rows in the array needed`, `no nulls although it is nullable`), it can see some improvement in the benchmark for function, but see no improvement in e2e benchmark(clickbench, tpch). I guess they may be not the hot path... I plan to not make further attempts recently... cc @Dandandan @alamb @jayzhan211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
