Rachelint commented on issue #13275: URL: https://github.com/apache/datafusion/issues/13275#issuecomment-2507419912
> Thanks @Rachelint for summarizing, that's interesting. One big difference between `take` + `eq` in join versus grouped aggregates seems to be that the `ValueBuilder`s already are type erased, so maybe there is nothing to gain (and using `take` and `eq` just creates an extra copy. > > It seems for the join code, this could actually be used more (and joining on string columns might be not so fast at the moment). 🤔 I think maybe we can indeed try some solutions without `take` in join? @LeslieKid seems trying it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
