comphead commented on code in PR #1111:
URL: https://github.com/apache/datafusion-comet/pull/1111#discussion_r1864453656
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1148,13 +1220,40 @@ impl PhysicalPlanner {
)?);
// If the hash join is build right, we need to swap the left
and right
- let hash_join = if join.build_side == BuildSide::BuildLeft as
i32 {
- hash_join
+ if join.build_side == BuildSide::BuildLeft as i32 {
+ Ok((
+ scans,
+ Arc::new(SparkPlan::new(
+ spark_plan.plan_id,
+ hash_join,
+ vec![join_params.left, join_params.right],
+ )),
+ ))
} else {
- swap_hash_join(hash_join.as_ref(),
PartitionMode::Partitioned)?
- };
-
- Ok((scans, hash_join))
+ // we insert a projection around the hash join in this case
+ let projection =
+ swap_hash_join(hash_join.as_ref(),
PartitionMode::Partitioned)?;
+ let swapped_hash_join =
Arc::clone(projection.children()[0]);
+ println!(
Review Comment:
is `println!` needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
