comphead commented on code in PR #1111:
URL: https://github.com/apache/datafusion-comet/pull/1111#discussion_r1855320601
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -365,28 +378,23 @@ struct ScanStream<'a> {
scan: ScanExec,
/// Schema representing the data
schema: SchemaRef,
- /// Metrics
- baseline_metrics: BaselineMetrics,
/// Cast options
cast_options: CastOptions<'a>,
/// elapsed time for casting columns to different data types during scan
cast_time: Time,
+ /// elapsed time for fetching arrow arrays from JVM
+ jvm_fetch_time: Time,
}
impl<'a> ScanStream<'a> {
- pub fn new(
- scan: ScanExec,
- schema: SchemaRef,
- partition: usize,
- baseline_metrics: BaselineMetrics,
- ) -> Self {
+ pub fn new(scan: ScanExec, schema: SchemaRef, partition: usize,
jvm_fetch_time: Time) -> Self {
Review Comment:
perhaps `jvm_fetch_time` enough for now, but if you wanna expand metrics in
future its better to have a wrapper structure similar to `BaselineMetrics` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
