iffyio commented on code in PR #1522: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1522#discussion_r1868169312
########## README.md: ########## @@ -63,12 +63,12 @@ The following optional [crate features](https://doc.rust-lang.org/cargo/referen * `serde`: Adds [Serde](https://serde.rs/) support by implementing `Serialize` and `Deserialize` for all AST nodes. * `visitor`: Adds a `Visitor` capable of recursively walking the AST tree. - +* `recursive-protection` (enabled by default), uses [recursive](https://docs.rs/recursive/latest/recursive/) for stack overflow protection. ## Syntax vs Semantics This crate provides only a syntax parser, and tries to avoid applying -any SQL semantics, and accepts queries that specific databases would +any SQL semantics, and accepts queries that specific databases wouldc Review Comment: ```suggestion any SQL semantics, and accepts queries that specific databases would ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
