alamb commented on code in PR #13651:
URL: https://github.com/apache/datafusion/pull/13651#discussion_r1870463166
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -451,6 +468,33 @@ impl Optimizer {
}
}
+/// These are invariants to hold true for each logical plan.
+/// Do necessary check and fail the invalid plan.
+///
+/// Checks for elements which are immutable across optimizer passes.
+fn check_plan(
+ check_name: &str,
+ plan: &LogicalPlan,
+ prev_schema: Arc<DFSchema>,
+) -> Result<()> {
+ // verify invariant: optimizer rule didn't change the schema
+ assert_schema_is_the_same(check_name, &prev_schema, plan)?;
+
+ // verify invariant: fields must have unique names
+ assert_unique_field_names(plan)?;
+
+ /* This current fails for:
+ - execution::context::tests::cross_catalog_access
+ - at test_files/string/string.slt:46
+ External error: query failed: DataFusion error: Optimizer rule
'eliminate_nested_union' failed
+ */
+ // verify invariant: equivalent schema across union inputs
+ // assert_unions_are_valid(check_name, plan)?;
Review Comment:
I think this function might be better as a method of LogicalPlan. Maybe
something like
```rust
LogicalPlan::check_invariants()
```
Or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
