Omega359 commented on PR #13651: URL: https://github.com/apache/datafusion/pull/13651#issuecomment-2519006923
I love the idea of having additional testing like this! It's definitely out of my area of expertise but a few questions: - Should invariants be pluggable? For example, Influxdb might have additional invariants that another derivative of DF does not (or vice versa)? - Is the invariant testing overhead acceptable for production or should it there be the capability to disable it (enabled by default of course!) ? - Is there an equivalent set of invariants elsewhere in the core besides the LP (maybe physical plan? Just guessing here as I'm definitely no expert here) where this approach could be duplicated ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
