Blizzara commented on code in PR #13647:
URL: https://github.com/apache/datafusion/pull/13647#discussion_r1870941733
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -2192,7 +2193,7 @@ fn substrait_field_ref(index: usize) ->
Result<Expression> {
}),
)),
})),
- root_type: None,
+ root_type: Some(RootType::RootReference(RootReference{}) ),
Review Comment:
Not necessary, but if you feel like it, could remove the duplication here:
split this function into `substrait_field_ref` that returns the FieldReference
and `substrait_field_ref_expr` that wraps it into Expression and then reusing
`substrait_field_ref` in the `try_to_substrait_field_reference`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
