Blizzara commented on code in PR #13647:
URL: https://github.com/apache/datafusion/pull/13647#discussion_r1873185289
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -2422,6 +2424,20 @@ mod test {
Ok(())
}
+ #[test]
+ fn to_field_reference() -> Result<()> {
+ let expression = substrait_field_ref(2)?;
+
+ match &expression.rex_type {
+ Some(RexType::Selection(field_ref)) => {
+ assert_ne!(field_ref.root_type, None);
Review Comment:
would this work?
```suggestion
assert_eq!(field_ref.root_type.expect("root type should be
set"), RootType::RootReference(RootReference {}));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
