iffyio commented on code in PR #1579:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1579#discussion_r1871558793
##########
src/parser/mod.rs:
##########
@@ -7273,6 +7273,10 @@ impl<'a> Parser<'a> {
let if_exists = self.parse_keywords(&[Keyword::IF,
Keyword::EXISTS]);
let name = self.parse_identifier(false)?;
AlterTableOperation::DropProjection { if_exists, name }
+ } else if dialect_of!(self is SnowflakeDialect | GenericDialect)
+ && self.parse_keywords(&[Keyword::CLUSTERING, Keyword::KEY])
Review Comment:
for the gating can we use a method on the dialect trait in place of the
`dialect_of!`? I'm thinking as well if it would make sense to one method to
represent these options since they belong to the same feature , e.g.
`supports_alter_table_clustering_action()` or similar method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
