yoavcloud commented on code in PR #1579:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1579#discussion_r1871655720
##########
src/parser/mod.rs:
##########
@@ -7273,6 +7273,10 @@ impl<'a> Parser<'a> {
let if_exists = self.parse_keywords(&[Keyword::IF,
Keyword::EXISTS]);
let name = self.parse_identifier(false)?;
AlterTableOperation::DropProjection { if_exists, name }
+ } else if dialect_of!(self is SnowflakeDialect | GenericDialect)
+ && self.parse_keywords(&[Keyword::CLUSTERING, Keyword::KEY])
Review Comment:
Perhaps we should drop the gate altogether in this case and introduce gating
as necessary? As of now, the gate will only help reject statements the dialect
shouldn't accept, vs. parsing incorrectly. Just a thought though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
