comphead commented on code in PR #13675:
URL: https://github.com/apache/datafusion/pull/13675#discussion_r1873717759
##########
datafusion/physical-expr/src/equivalence/class.rs:
##########
@@ -546,20 +546,15 @@ impl EquivalenceGroup {
.collect::<Vec<_>>();
(new_class.len() > 1).then_some(EquivalenceClass::new(new_class))
});
- // TODO: Convert the algorithm below to a version that uses `HashMap`.
- // once `Arc<dyn PhysicalExpr>` can be stored in `HashMap`.
- // See issue: https://github.com/apache/datafusion/issues/8027
- let mut new_classes = vec![];
+ let mut new_classes: IndexMap<Arc<dyn PhysicalExpr>, Vec<Arc<dyn
PhysicalExpr>>> =
Review Comment:
should we comment what is the key and what is the value in the map? PhyExpr
is too abstract imho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
