Weijun-H commented on PR #13675:
URL: https://github.com/apache/datafusion/pull/13675#issuecomment-2533645128
> I see much less difference this time 🤔 (I also ran `cargo update` which
might have helped)
>
> ```
> ++ critcmp main 8027-refactor-hashmap
> group 8027-refactor-hashmap
main
> ----- ---------------------
----
> logical_aggregate_with_join 1.00 1488.6±14.22µs
? ?/sec 1.00 1485.6±13.32µs ? ?/sec
> logical_select_all_from_1000 1.01 5.3±0.03ms
? ?/sec 1.00 5.3±0.02ms ? ?/sec
> logical_select_one_from_700 1.01 1197.6±43.93µs
? ?/sec 1.00 1182.6±29.15µs ? ?/sec
> logical_trivial_join_high_numbered_columns 1.01 1156.1±12.46µs
? ?/sec 1.00 1147.7±13.89µs ? ?/sec
> logical_trivial_join_low_numbered_columns 1.00 1140.9±18.42µs
? ?/sec 1.00 1137.8±24.82µs ? ?/sec
> physical_intersection 1.01 2.4±0.03ms
? ?/sec 1.00 2.4±0.02ms ? ?/sec
> physical_join_consider_sort 1.01 3.3±0.02ms
? ?/sec 1.00 3.3±0.04ms ? ?/sec
> physical_join_distinct 1.01 1134.1±17.15µs
? ?/sec 1.00 1120.3±15.60µs ? ?/sec
> physical_many_self_joins 1.02 17.4±0.10ms
? ?/sec 1.00 17.1±0.10ms ? ?/sec
> physical_plan_clickbench_all 1.00 229.4±2.10ms
? ?/sec 1.00 229.4±1.97ms ? ?/sec
> physical_plan_clickbench_q1 1.00 3.3±0.03ms
? ?/sec 1.00 3.3±0.04ms ? ?/sec
> physical_plan_clickbench_q10 1.00 4.4±0.05ms
? ?/sec 1.00 4.4±0.05ms ? ?/sec
> physical_plan_clickbench_q11 1.00 4.5±0.06ms
? ?/sec 1.00 4.5±0.12ms ? ?/sec
> physical_plan_clickbench_q12 1.00 4.7±0.07ms
? ?/sec 1.00 4.7±0.06ms ? ?/sec
> physical_plan_clickbench_q13 1.01 4.3±0.08ms
? ?/sec 1.00 4.3±0.04ms ? ?/sec
> physical_plan_clickbench_q14 1.00 4.5±0.07ms
? ?/sec 1.00 4.5±0.08ms ? ?/sec
> physical_plan_clickbench_q15 1.00 4.4±0.07ms
? ?/sec 1.00 4.4±0.08ms ? ?/sec
> physical_plan_clickbench_q16 1.00 3.8±0.07ms
? ?/sec 1.00 3.8±0.05ms ? ?/sec
> physical_plan_clickbench_q17 1.00 3.9±0.05ms
? ?/sec 1.00 3.9±0.06ms ? ?/sec
> physical_plan_clickbench_q18 1.00 3.6±0.07ms
? ?/sec 1.00 3.6±0.06ms ? ?/sec
> physical_plan_clickbench_q19 1.01 4.6±0.07ms
? ?/sec 1.00 4.5±0.05ms ? ?/sec
> physical_plan_clickbench_q2 1.00 3.6±0.04ms
? ?/sec 1.00 3.6±0.04ms ? ?/sec
> physical_plan_clickbench_q20 1.00 3.4±0.04ms
? ?/sec 1.00 3.4±0.04ms ? ?/sec
> physical_plan_clickbench_q21 1.00 3.6±0.06ms
? ?/sec 1.00 3.6±0.05ms ? ?/sec
> physical_plan_clickbench_q22 1.00 4.6±0.07ms
? ?/sec 1.00 4.6±0.08ms ? ?/sec
> physical_plan_clickbench_q23 1.00 5.1±0.08ms
? ?/sec 1.00 5.1±0.07ms ? ?/sec
> physical_plan_clickbench_q24 1.00 5.8±0.11ms
? ?/sec 1.01 5.8±0.07ms ? ?/sec
> physical_plan_clickbench_q25 1.00 4.0±0.06ms
? ?/sec 1.00 4.0±0.04ms ? ?/sec
> physical_plan_clickbench_q26 1.00 3.7±0.06ms
? ?/sec 1.00 3.7±0.04ms ? ?/sec
> physical_plan_clickbench_q27 1.00 4.0±0.09ms
? ?/sec 1.00 4.0±0.06ms ? ?/sec
> physical_plan_clickbench_q28 1.00 4.8±0.08ms
? ?/sec 1.00 4.8±0.09ms ? ?/sec
> physical_plan_clickbench_q29 1.00 5.9±0.13ms
? ?/sec 1.00 5.9±0.08ms ? ?/sec
> physical_plan_clickbench_q3 1.00 3.6±0.04ms
? ?/sec 1.00 3.5±0.04ms ? ?/sec
> physical_plan_clickbench_q30 1.00 16.8±0.23ms
? ?/sec 1.00 16.8±0.21ms ? ?/sec
> physical_plan_clickbench_q31 1.00 4.9±0.08ms
? ?/sec 1.00 4.9±0.07ms ? ?/sec
> physical_plan_clickbench_q32 1.01 4.9±0.08ms
? ?/sec 1.00 4.8±0.05ms ? ?/sec
> physical_plan_clickbench_q33 1.00 4.4±0.06ms
? ?/sec 1.00 4.4±0.08ms ? ?/sec
> physical_plan_clickbench_q34 1.00 3.9±0.05ms
? ?/sec 1.00 3.9±0.04ms ? ?/sec
> physical_plan_clickbench_q35 1.00 4.1±0.05ms
? ?/sec 1.00 4.1±0.05ms ? ?/sec
> physical_plan_clickbench_q36 1.00 5.2±0.07ms
? ?/sec 1.00 5.2±0.07ms ? ?/sec
> physical_plan_clickbench_q37 1.00 5.3±0.07ms
? ?/sec 1.00 5.3±0.07ms ? ?/sec
> physical_plan_clickbench_q38 1.00 5.3±0.07ms
? ?/sec 1.00 5.3±0.08ms ? ?/sec
> physical_plan_clickbench_q39 1.00 4.8±0.07ms
? ?/sec 1.00 4.8±0.07ms ? ?/sec
> physical_plan_clickbench_q4 1.00 3.3±0.03ms
? ?/sec 1.01 3.4±0.04ms ? ?/sec
> physical_plan_clickbench_q40 1.01 5.5±0.08ms
? ?/sec 1.00 5.4±0.08ms ? ?/sec
> physical_plan_clickbench_q41 1.01 5.2±0.12ms
? ?/sec 1.00 5.2±0.07ms ? ?/sec
> physical_plan_clickbench_q42 1.00 5.0±0.08ms
? ?/sec 1.00 5.0±0.07ms ? ?/sec
> physical_plan_clickbench_q43 1.00 5.1±0.08ms
? ?/sec 1.00 5.1±0.07ms ? ?/sec
> physical_plan_clickbench_q44 1.00 3.5±0.04ms
? ?/sec 1.00 3.5±0.04ms ? ?/sec
> physical_plan_clickbench_q45 1.00 3.5±0.04ms
? ?/sec 1.00 3.5±0.05ms ? ?/sec
> physical_plan_clickbench_q46 1.00 4.1±0.05ms
? ?/sec 1.00 4.1±0.06ms ? ?/sec
> physical_plan_clickbench_q47 1.00 4.8±0.06ms
? ?/sec 1.00 4.8±0.10ms ? ?/sec
> physical_plan_clickbench_q48 1.00 5.4±0.07ms
? ?/sec 1.00 5.4±0.07ms ? ?/sec
> physical_plan_clickbench_q49 1.01 5.7±0.10ms
? ?/sec 1.00 5.7±0.08ms ? ?/sec
> physical_plan_clickbench_q5 1.00 3.6±0.05ms
? ?/sec 1.00 3.6±0.05ms ? ?/sec
> physical_plan_clickbench_q6 1.01 3.6±0.05ms
? ?/sec 1.00 3.6±0.05ms ? ?/sec
> physical_plan_clickbench_q7 1.00 4.1±0.06ms
? ?/sec 1.00 4.1±0.04ms ? ?/sec
> physical_plan_clickbench_q8 1.00 3.9±0.06ms
? ?/sec 1.00 3.8±0.08ms ? ?/sec
> physical_plan_clickbench_q9 1.00 4.2±0.06ms
? ?/sec 1.00 4.2±0.07ms ? ?/sec
> physical_plan_tpcds_all 1.01 1385.2±6.74ms
? ?/sec 1.00 1370.7±3.03ms ? ?/sec
> physical_plan_tpch_all 1.01 90.6±0.49ms
? ?/sec 1.00 90.0±0.79ms ? ?/sec
> physical_plan_tpch_q1 1.01 3.3±0.08ms
? ?/sec 1.00 3.2±0.02ms ? ?/sec
> physical_plan_tpch_q10 1.02 4.5±0.03ms
? ?/sec 1.00 4.4±0.05ms ? ?/sec
> physical_plan_tpch_q11 1.00 4.0±0.02ms
? ?/sec 1.00 3.9±0.03ms ? ?/sec
> physical_plan_tpch_q12 1.00 3.1±0.02ms
? ?/sec 1.00 3.1±0.02ms ? ?/sec
> physical_plan_tpch_q13 1.01 2.5±0.03ms
? ?/sec 1.00 2.4±0.02ms ? ?/sec
> physical_plan_tpch_q14 1.01 2.8±0.02ms
? ?/sec 1.00 2.8±0.02ms ? ?/sec
> physical_plan_tpch_q16 1.00 3.9±0.02ms
? ?/sec 1.00 3.9±0.04ms ? ?/sec
> physical_plan_tpch_q17 1.00 3.7±0.03ms
? ?/sec 1.00 3.7±0.04ms ? ?/sec
> physical_plan_tpch_q18 1.01 4.1±0.05ms
? ?/sec 1.00 4.1±0.04ms ? ?/sec
> physical_plan_tpch_q19 1.00 5.9±0.03ms
? ?/sec 1.00 5.9±0.03ms ? ?/sec
> physical_plan_tpch_q2 1.01 7.5±0.03ms
? ?/sec 1.00 7.5±0.06ms ? ?/sec
> physical_plan_tpch_q20 1.00 4.8±0.04ms
? ?/sec 1.00 4.7±0.04ms ? ?/sec
> physical_plan_tpch_q21 1.00 6.1±0.05ms
? ?/sec 1.00 6.1±0.04ms ? ?/sec
> physical_plan_tpch_q22 1.00 3.6±0.02ms
? ?/sec 1.00 3.6±0.02ms ? ?/sec
> physical_plan_tpch_q3 1.01 3.3±0.02ms
? ?/sec 1.00 3.2±0.02ms ? ?/sec
> physical_plan_tpch_q4 1.00 2.6±0.02ms
? ?/sec 1.00 2.6±0.02ms ? ?/sec
> physical_plan_tpch_q5 1.00 4.5±0.06ms
? ?/sec 1.00 4.4±0.03ms ? ?/sec
> physical_plan_tpch_q6 1.01 1875.2±83.61µs
? ?/sec 1.00 1863.0±15.01µs ? ?/sec
> physical_plan_tpch_q7 1.01 5.8±0.04ms
? ?/sec 1.00 5.8±0.07ms ? ?/sec
> physical_plan_tpch_q8 1.01 6.9±0.05ms
? ?/sec 1.00 6.8±0.03ms ? ?/sec
> physical_plan_tpch_q9 1.02 5.5±0.05ms
? ?/sec 1.00 5.4±0.03ms ? ?/sec
> physical_select_aggregates_from_200 1.00 25.7±0.14ms
? ?/sec 1.02 26.2±0.16ms ? ?/sec
> physical_select_all_from_1000 1.00 41.1±0.20ms
? ?/sec 1.00 41.1±0.20ms ? ?/sec
> physical_select_one_from_700 1.02 3.4±0.02ms
? ?/sec 1.00 3.3±0.03ms ? ?/sec
> physical_theta_join_consider_sort 1.01 3.7±0.02ms
? ?/sec 1.00 3.7±0.03ms ? ?/sec
> physical_unnest_to_join 1.01 3.4±0.02ms
? ?/sec 1.00 3.3±0.02ms ? ?/sec
> with_param_values_many_columns 1.01 162.1±1.21µs
? ?/sec 1.00 160.2±0.74µs ? ?/sec
> ```
Most of the queries have improved. Can we merge this pull request? What do
you think? @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
