goldmedal commented on code in PR #1551:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1551#discussion_r1876302358
##########
src/dialect/snowflake.rs:
##########
@@ -234,6 +234,10 @@ impl Dialect for SnowflakeDialect {
RESERVED_FOR_IDENTIFIER.contains(&kw)
}
}
+
+ fn supports_partiql(&self) -> bool {
+ true
+ }
Review Comment:
I tried to integrate the conditions at
https://github.com/apache/datafusion-sqlparser-rs/blob/d0fcc06652ba9880622d0ef8b426c809cee752fe/src/parser/mod.rs#L2998-L3000
Then, we can only check `supports_partiql` in `parse_compound_expr`. 🤔
```
if self.consume_token(&Token::LBracket) {
if self.dialect.supports_partiql() {
ending_lbracket = true;
break;
} else {
self.parse_multi_dim_subscript(&mut chain)?
}
}
```
Indeed, the name is a little weird for `Snowflake` but I think they mean the
same thing 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
