findepi commented on code in PR #13708:
URL: https://github.com/apache/datafusion/pull/13708#discussion_r1877895988
##########
datafusion/expr/src/expr.rs:
##########
@@ -840,6 +840,12 @@ impl WindowFunction {
}
}
+/// Find DataFusion's built-in window function by name.
+#[deprecated(since = "44.0.0", note = "built-in window functions have been
removed")]
+pub fn find_df_window_func(_name: &str) -> Option<WindowFunctionDefinition> {
+ None
Review Comment:
As someone who did upgrades, I'd appreciate a compiler error more than a
dummy implementation.
But we can do good here. We can see what's the name being looked up and
return non-built-in implementation based on that. The return type allows to do
this, fortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
