andygrove commented on code in PR #13708: URL: https://github.com/apache/datafusion/pull/13708#discussion_r1878459451
########## datafusion/expr/src/expr.rs: ########## @@ -840,6 +840,12 @@ impl WindowFunction { } } +/// Find DataFusion's built-in window function by name. +#[deprecated(since = "44.0.0", note = "built-in window functions have been removed")] Review Comment: I'll have to research what the replacement API is first, but yes, that would be good. Once I have Comet tests passing, I will come back and improve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org