davisp opened a new pull request, #1590: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1590
This updates the keyword lookup algorthm to use the phf crate. This is one possible approach to solving #1588 at the cost of pulling in a new dependency on [phf](https://crates.io/crates/phf). I will note that phf is rather small and is being used in a `no_std` configuration, but it is a new dependency which may be enough to not go this route. Local measuring with the sqlparser_bench shows roughly a 5% speedup. I'll open a second PR for comparison with my other approach to just scope the binary search to words starting with the same first letter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
