alamb commented on PR #1590: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1590#issuecomment-2539333487
As much as I love not rewriting code, I am quite loath to take on a new dependency in this crate. My concerns are 1. The binary / dependency size 2. (mostly) that every additional crate used results in another places to help maintain (see for example https://github.com/apache/arrow-rs/issues/6858) That being said, `phf` appears to be widely used and not changing: https://crates.io/crates/phf/reverse_dependencies Are you wiling to try the "compare without allocating approach" described in https://github.com/apache/datafusion-sqlparser-rs/pull/1591#discussion_r1882405987? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
